TimerSet now survives a fork. #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
God catch! thank you very much for doing this. |
|
@jdantonio thanks for merging. My pleasure, thanks for maintaining an excellent library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar in spirit to #501: when a fork is detected, immediately:
I found this issue while debugging a Gem I am working on which uses a
Concurrent::TimerTaskbehind the scenes. If I started any tasks before a fork, they didn't survive, but the bug was that no moreTimerTasks could be started after that.This allows new
TimerTasks to be created after a fork.