Skip to content

Avoid RSpec monkey patching, persist spec results locally, use RSpec v3.7.0 #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2018
Merged

Avoid RSpec monkey patching, persist spec results locally, use RSpec v3.7.0 #680

merged 1 commit into from
Feb 21, 2018

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Nov 18, 2017 •
edited
Loading

This PR is mechanical configuration of RSpec.

@olleolleolle olleolleolle changed the title RSpec - avoid monkey patching RSpec - avoid monkey patching, persist spec run results locally Nov 18, 2017
@olleolleolle olleolleolle changed the title RSpec - avoid monkey patching, persist spec run results locally RSpec - avoid monkey patching, persist spec run results locally, update to 3.7 Nov 18, 2017
@olleolleolle
Copy link
Contributor Author

@pitr-ch All was much easier to get done than I feared.

@jdantonio
Copy link
Member

There appears to be a problem with an Actor test causing a deadlock on some Java builds. I'm seeing the same timeout on numerous PRs. The last passing test is forbids Immediate executor after which nothing happens and Travis kills the run.

@pitr-ch for visibility

@pitr-ch pitr-ch added this to the 1.1.0 milestone Dec 4, 2017
@olleolleolle olleolleolle changed the title RSpec - avoid monkey patching, persist spec run results locally, update to 3.7 Avoid RSpec monkey patching, persist spec results locally, use RSpec v3.7.0 Dec 9, 2017
@olleolleolle @pitr-ch
RSpec - avoid monkey patching
01f5397 
  - configure --only-failures feature
@ghost ghost assigned pitr-ch Feb 21, 2018
@ghost ghost added the in progress label Feb 21, 2018
@pitr-ch
Copy link
Member

pitr-ch commented Feb 21, 2018

I've rebased on master to rerun CI.

@pitr-ch pitr-ch merged commit 3007dad into ruby-concurrency:master Feb 21, 2018
@ghost ghost removed the in progress label Feb 21, 2018
@olleolleolle olleolleolle deleted the fix/update-rspec branch February 21, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitr-ch pitr-ch pitr-ch approved these changes

Assignees

@pitr-ch pitr-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olleolleolle @jdantonio @pitr-ch