Skip to content

Fix NameError on defining a struct with a name #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Slike9
Copy link
Contributor

@Slike9 Slike9 commented Nov 6, 2018

Fix NameError on defining a struct with a name when a constant with the same name already exists in the ancestors, e.g. in Object (global space).

Fix `NameError` on defining a struct with a name when a constant with
the same name already exists in the ancestors, e.g. in `Object` (global
space).
Baelor added a commit to OmertaBeyond/omerta_logger that referenced this pull request Nov 7, 2018
concurrent-ruby causes issues with the config gem, see
ruby-concurrency/concurrent-ruby#776
@pitr-ch pitr-ch added the bug A bug in the library or documentation. label Nov 8, 2018
Copy link
Member

@pitr-ch pitr-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pitr-ch pitr-ch merged commit dd6b5f5 into ruby-concurrency:master Nov 8, 2018
@kapso
Copy link

kapso commented Nov 16, 2018

@Slike9 thanks for the fix!

@pitr-ch curious, any plans of releasing a new version with this fix?

@pitr-ch
Copy link
Member

pitr-ch commented Dec 6, 2018

@kapso I'll do another patch release in few days.

@kapso
Copy link

kapso commented Dec 17, 2018

@pitr-ch any chances of getting this out soon?

@pitr-ch
Copy link
Member

pitr-ch commented Dec 17, 2018

@kapso It went out in 1.1.4 release on last Saturday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the library or documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants