New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameError on defining a struct with a name #776

Merged
merged 1 commit into from Nov 8, 2018

Conversation

3 participants
@Slike9
Contributor

Slike9 commented Nov 6, 2018

Fix NameError on defining a struct with a name when a constant with the same name already exists in the ancestors, e.g. in Object (global space).

Fix NameError on defining a struct with a name
Fix `NameError` on defining a struct with a name when a constant with
the same name already exists in the ancestors, e.g. in `Object` (global
space).

Baelor added a commit to Baelor/omerta_logger that referenced this pull request Nov 7, 2018

Pin concurrent-ruby to < 1.1.0
concurrent-ruby causes issues with the config gem, see
ruby-concurrency/concurrent-ruby#776

@pitr-ch pitr-ch added the bug label Nov 8, 2018

@pitr-ch

pitr-ch approved these changes Nov 8, 2018

Thanks for the fix!

@pitr-ch pitr-ch merged commit dd6b5f5 into ruby-concurrency:master Nov 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment