Skip to content

CI: Add Ruby 2.6.0 to matrix #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 1, 2019
Merged

Conversation

olleolleolle
Copy link
Contributor

This PR adds latest MRI to the matrix.

  • remove 2.6.0-rc1

  - remove 2.6.0-rc1
@pitr-ch
Copy link
Member

pitr-ch commented Dec 31, 2018

Thanks.

     - name: MRI 2.5.1
       rvm: 2.5.1	     

The above should be added so we keep testing all minor versions.

@pitr-ch
Copy link
Member

pitr-ch commented Dec 31, 2018

Do you know why the 1.9.3 is running so old bundler? 1.17.3 bundler still supports 1.9.3.

@olleolleolle
Copy link
Contributor Author

@pitr-ch We can add a before_install to 1.9.3's matrix item, and do a gem install bundler there.

@olleolleolle
Copy link
Contributor Author

@pitr-ch I added 2.5, and also a before_install for 1.9.3.

@ghost ghost assigned pitr-ch Jan 1, 2019
@ghost ghost added the in progress label Jan 1, 2019
Copy link
Member

@pitr-ch pitr-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that works. I did one more cosmetic change, then when it's green I'll merge it.

@pitr-ch pitr-ch merged commit 5e18636 into ruby-concurrency:master Jan 1, 2019
@ghost ghost removed the in progress label Jan 1, 2019
@pitr-ch pitr-ch added the chore Gem maintenance tasks. label Jan 1, 2019
@olleolleolle olleolleolle deleted the patch-4 branch January 1, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Gem maintenance tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants