-
Notifications
You must be signed in to change notification settings - Fork 419
Specs: Use latest timecop v0.9.4, to fix ruby-head #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specs: Use latest timecop v0.9.4, to fix ruby-head #914
Conversation
@pitr-ch 👋 I think I made one of the matrix elements pass! At what cost? We'll learn. Update I took a look around, and could not find any obviously-broken details connected to Timecop changes. |
Can you please rebase? |
This sets it to a non-exact version.
a7f6ac5
to
cad0863
Compare
@chrisseaton 🟢 Rebased! |
Thanks for your fix. |
Does this make any of the experimentals less experimental? |
Which experimental Ruby versions? I need to try to get a grip on what Ruby versions we officially claim to support and document it and reflect it in CI. |
@chrisseaton There are 2 workflows in CI, one being scheduled to run at midnight, and targets [head, truffleruby, truffleruby-head]. The regular ci.yml one includes 2.4 and up, including latest The gemspec requires a Ruby 1.9.3+... (Sorry, these are just random facts, which do not contribute to making an understanding of what you mentioned.) Counter-note: I was running around in the codebase looking for opportunities to use
|
The "Supported Ruby Versions" section claims 2.0+ - so we could go to use https://github.com/ruby-concurrency/concurrent-ruby#supported-ruby-versions |
This PR asks for a Timecop with a non-exact version,
0.9
, which resolves to 0.9.4. That version supports Ruby 3.1 aka ruby-head. Timecop changelog.Background
Last commit to that line in the Gemfile was 6 years ago, with exact versions everywhere. 4cfd9c7
Result
With this version of timecop, concurrent-ruby is green 🟢 on ruby-head.
This was in one of the GitHub Actions results: https://github.com/ruby-concurrency/concurrent-ruby/runs/2848609176#step:4:94