Add Ruby 3.1 to CI #930
Merged
Add Ruby 3.1 to CI #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paprikas
reviewed
Jan 10, 2022
| @@ -8,7 +8,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: [2.4, 2.5, 2.6, 2.7, 3.0, jruby, jruby-head] | |||
| ruby: [2.4, 2.5, 2.6, 2.7, '3.0', 3.1, jruby, jruby-head] | |||
There was a problem hiding this comment.
Quotes are required around 3.0 because of how YAML parses floats. Without quotes, 3.0 gets treated as 3 - the additional precision is lost. And so It will attempt to load the latest Ruby version matching '3', which will be a 3.1 version.
To ensure 3.0 actually tests a Ruby 3.0.x you need to wrap it in quotes.
|
I'm not sure exactly why jruby-head is failing, but it appears unrelated. |
|
Thanks for the contribution. Sorry yes CI isn't always in a great state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.