Travis is done and never coming back #946
Conversation
| @@ -2,14 +2,7 @@ | |||
| require 'simplecov' | |||
| require 'coveralls' | |||
|
|
|||
| if ENV['TRAVIS'] | |||
There was a problem hiding this comment.
Should it be ENV['CI'] instead?
There was a problem hiding this comment.
The branch hasn't been run the whole time we've been using GitHub Actions. If we want a different coverage output format in the future we can pick it then.
| @@ -148,7 +148,7 @@ def on_message(message) | |||
| end | |||
| end | |||
|
|
|||
| it 'terminates with all its children', notravis: true do | |||
There was a problem hiding this comment.
I wonder if this tag was somehow avoiding running transient tests in CI.
Maybe the failure in https://github.com/ruby-concurrency/concurrent-ruby/runs/5553488676?check_suite_focus=true is related (but maybe not)
There was a problem hiding this comment.
Given the Rakefile above it sounds like they were excluded, even on GitHub Actions before this PR
There was a problem hiding this comment.
Doesn't seem to be related to that particular failure - which I think is a relatively new spec anyway?
No description provided.