Skip to content

#14 skip() doesn't mutate the instance #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

#14 skip() doesn't mutate the instance #15

merged 1 commit into from
Apr 28, 2020

Conversation

amihaiemil
Copy link
Member

Fixes #14
Class FromArray should always be immutable and thread-safe.

@amihaiemil
Copy link
Member Author

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Apr 28, 2020

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c301c45 into master Apr 28, 2020
@amihaiemil amihaiemil deleted the 14 branch April 28, 2020 14:02
@rultor
Copy link
Collaborator

rultor commented Apr 28, 2020

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method skip(...) Should Not Mutate The Class
2 participants
@amihaiemil @rultor