Skip to content

#14 skip() doesn't mutate the instance #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2020
Merged

#14 skip() doesn't mutate the instance #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/fromarray.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

module Stream
# A stream implemented based on an Array.
# This class is immutable and thread-safe.
# Author:: Mihai Andronache (amihaiemil@gmail.com)
class FromArray
def initialize(array)
Expand All @@ -38,8 +39,7 @@ def skip(count)
@array.each_with_index do |val, index|
skipped.push(val) unless index + 1 <= count
end
@array = skipped
self
FromArray.new(skipped)
end

# Collect the stream's data into an array and return it.
Expand Down
4 changes: 2 additions & 2 deletions test/fromarray_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ def test_skip_argument_error_count_negative
def test_skip_returns_self
stream = FromArray.new([1, 2, 3])
assert(
stream.skip(1).equal?(stream),
'Method skip should return the modified stream'
!stream.skip(1).equal?(stream),
'Method skip should return a new instance of the modified stream'
)
end

Expand Down