fixed the implementation of Bignum#to_ber.

Author: blackhedd

Rakefile

@@ -72,7 +72,7 @@ end
 
 desc "(Provisional) Run tests for SNMP"
 task :test_snmp do |t|
-  run_test_set t, ['tests/testsnmp.rb']
+  run_test_set t, ['tests/testsnmp.rb', 'tests/testber.rb']
 end
 
 spec = eval(File.read("net-ldap.gemspec"))

lib/net/ber.rb

@@ -409,9 +409,22 @@ def to_ber_length_encoding
 class Bignum
 
   def to_ber
-    i = [self].pack('w')
-    i.length > 126 and raise Net::BER::BerError.new( "range error in bignum" )
-    [2, i.length].pack("CC") + i
+    #i = [self].pack('w')
+    #i.length > 126 and raise Net::BER::BerError.new( "range error in bignum" )
+    #[2, i.length].pack("CC") + i
+
+    # Ruby represents Bignums as two's-complement numbers so we may actually be
+    # good as far as representing negatives goes.
+    # I'm sure this implementation can be improved performance-wise if necessary.
+    sz = self.size
+    out = "\000" * sz
+    (sz*8).times {|bit|
+	if self[bit] == 1
+	    out[bit/8] += (1 << (bit % 8))
+	end
+    }
+
+    [2, sz].pack("CC") + out.reverse
   end
 
 end

tests/testber.rb

@@ -23,6 +23,28 @@ def test_ber_integers
     assert_equal( "\002\005\222\320\227\344\000", 5000000000.to_ber )
   end
 
+  def test_ber_bignums
+      # Some of these values are Fixnums and some are Bignums. Different BER code.
+      [
+	  5,
+	  50,
+	  500,
+	  5000,
+	  50000,
+	  500000,
+	  5000000,
+	  50000000,
+	  500000000,
+	  1000000000,
+	  2000000000,
+	  3000000000,
+	  4000000000,
+	  5000000000
+      ].each {|val|
+	  assert_equal( val, val.to_ber.read_ber )
+      }
+  end
+
   def test_ber_parsing
     assert_equal( 6, "\002\001\006".read_ber( Net::LDAP::AsnSyntax ))
     assert_equal( "testing", "\004\007testing".read_ber( Net::LDAP::AsnSyntax ))