Do not add controls when it is empty. Fixed #17 #18

Merged
merged 1 commit into from Dec 5, 2011

Conversation

Projects
None yet
3 participants
Contributor

doitian commented Aug 10, 2011

Some LDAP servers, such as ApacheDS, consider as invalid protocol, if controls
is an empty array.

Do not add controls when it is empty. Fixed #17
Some LDAP servers, such as ApacheDS, consider as invalid protocol, if controls
is an empty array.
Contributor

Jamstah commented Sep 5, 2011

Can you add a test case for this change?

RoryO added a commit that referenced this pull request Dec 5, 2011

Merge pull request #18 from doitian/issue/17_bererror_unsupported_obj…
…ect_type_id_139

Do not add controls when it is empty. Fixed #17

@RoryO RoryO merged commit a1bf790 into ruby-ldap:master Dec 5, 2011

@jrafanie jrafanie referenced this pull request in ManageIQ/manageiq Sep 4, 2014

Merged

Upgrade net-ldap for fix for LDAP Controls. #505

jrafanie added a commit to jrafanie/manageiq that referenced this pull request Sep 4, 2014

Upgrade net-ldap for fix for LDAP Controls.
https://bugzilla.redhat.com/show_bug.cgi?id=956833

net-ping at 1.5.3 required net-ldap at ~>0.2.2, so we need to upgrade net-ping also.

See: ruby-ldap/ruby-net-ldap#18

In upgrading from 0.2.2 to latest, 0.7.0, the change we need is here:
ruby-ldap/ruby-net-ldap@v0.2.2...v0.7.0#diff-724e0b3130dc49ca34eadc7c25d28b18R1647.
We want to be able to compact any nil control_codes.

astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015

Merge pull request #18 from doitian/issue/17_bererror_unsupported_obj…
…ect_type_id_139

Do not add controls when it is empty. Fixed #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment