2.0.6 uses different token to 2.0.5 #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 419 419
=========================================
Hits 419 419
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
We have encountered the same issue with
Thank you 🥳 |
|
@vhiairrassary @rickselby Thanks for the reports. The release 2.0.7 should fix this, and be available now. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 28, 2022
https://build.opensuse.org/request/show/1010030 by user coolo + dimstar_suse updated to version 2.0.9 see installed CHANGELOG.md updated to version 2.0.7 see installed CHANGELOG.md ## [2.0.7] - 2022-08-22 ### Added - [#629](ruby-oauth/oauth2#629) - Allow POST of JSON to get token (@pboling, @terracatta) ### Fixed - [#626](ruby-oauth/oauth2#626) - Fixes a regression in 2.0.6. Will now prefer the key order from the lookup, not the hash keys (@rickselby) - Note: This fixes compatibility with `omniauth-oauth2` and AWS - [#625](ruby-oauth/oauth2#625) - Fixes the printed version in the post install message (@hasghari) updated to version 2.0.6 see installed CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll start by saying I'm just a user of the gem, I have no idea how the oauth2 process works, we use it with omniauth and cognito for authentication in AWS.
When upgrading to 2.0.6, our logins broke. On investigation, I see the following in the logs:
Looking at the code changes from #624, the
access_tokenwas previously being preferred over theid_token, so I'm assuming this is the bug.I've corrected this and added a test to ensure the gem will still function as it did before.