return when line is nil
#664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@sock.gets` can return `nil` if `@sock` is closed. Return this method and cleanup the server connection. fix #622
st0012
reviewed
Jun 27, 2022
| } | ||
| end | ||
|
|
||
| return unless line |
There was a problem hiding this comment.
If the nil is expected after the Socket is closed, I think it'd be clearer if we dear with it around line 162. For example:
if line = @sock.gets
DEBUGGER__.info "UI_Server received: #{line.chomp}"
line
else
# socket is closed
return
endThere was a problem hiding this comment.
Now the lines are already complicated so I left it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sock.getscan returnnilif@sockis closed.Return this method and cleanup the server connection.
fix #622