Skip to content

return when line is nil #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

return when line is nil #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/debug/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def process
}
end

return unless line
Copy link
Member

@st0012 st0012 Jun 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the nil is expected after the Socket is closed, I think it'd be clearer if we dear with it around line 162. For example:

         if line = @sock.gets
           DEBUGGER__.info "UI_Server received: #{line.chomp}"
           line
         else
           # socket is closed
           return
         end

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the lines are already complicated so I left it.

next if line == :can_not_read

case line
Expand All @@ -187,7 +188,7 @@ def process
raise "pid:#{Process.pid} but get #{line}"
end
else
STDERR.puts "unsupported: #{line}"
STDERR.puts "unsupported: #{line.inspect}"
exit!
end
end
Expand Down