asn1integer_to_num: don't cast away const

botovq · botovq · commit d0f36a7c6550 · 2025-12-06T18:03:31.000+01:00
ASN1_ENUMERATED_to_BN() has been const-correct for a long time in all
supported libcrytos, so we can remove this workaround.
diff --git a/ext/openssl/ossl_asn1.c b/ext/openssl/ossl_asn1.c
@@ -131,8 +131,7 @@ asn1integer_to_num(const ASN1_INTEGER *ai)
         ossl_raise(rb_eTypeError, "ASN1_INTEGER is NULL!");
     }
     if (ASN1_STRING_type(ai) == V_ASN1_ENUMERATED)
-        /* const_cast: workaround for old OpenSSL */
-        bn = ASN1_ENUMERATED_to_BN((ASN1_ENUMERATED *)ai, NULL);
+        bn = ASN1_ENUMERATED_to_BN(ai, NULL);
     else
         bn = ASN1_INTEGER_to_BN(ai, NULL);
 

Original file line number	Diff line number	Diff line change
`@@ -131,8 +131,7 @@ asn1integer_to_num(const ASN1_INTEGER *ai)`
`131`	`131`	`ossl_raise(rb_eTypeError, "ASN1_INTEGER is NULL!");`
`132`	`132`	`}`
`133`	`133`	`if (ASN1_STRING_type(ai) == V_ASN1_ENUMERATED)`
`134`		`- /* const_cast: workaround for old OpenSSL */`
`135`		`- bn = ASN1_ENUMERATED_to_BN((ASN1_ENUMERATED *)ai, NULL);`
	`134`	`+ bn = ASN1_ENUMERATED_to_BN(ai, NULL);`
`136`	`135`	`else`
`137`	`136`	`bn = ASN1_INTEGER_to_BN(ai, NULL);`
`138`	`137`