Fix chained inclusion ancestors_of #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #814 Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
|
Thanks for the patch and kind consideration. First of all, this is a great Pull Request. I'll merge it. Next, about tests, I always make it clear where to load files from, like |
nobu
pushed a commit
to nobu/rdoc
that referenced
this pull request
Sep 12, 2021
This patch makes sure we only load relative code. Hence when coding or testing rdoc, we'll be sure to always be using the correct code. Discussion started at ruby#817. Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
nobu
added a commit
that referenced
this pull request
Feb 10, 2022
This patch makes sure we only load relative code. Hence when coding or testing rdoc, we'll be sure to always be using the correct code. Discussion started at #817. Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com> Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 12, 2022
This patch makes sure we only load relative code. Hence when coding or testing rdoc, we'll be sure to always be using the correct code. Discussion started at ruby/rdoc#817. Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com> ruby/rdoc@aa41bd48eb Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814
(thanks for the great gem ❤️)
In the process of doing this PR I bumped on a dev issue. I was running tests like
ruby test/rdoc/test_rdoc_ri_driver.rb --name=test_ancestors_of_chained_inclusionand it was loading the wrong rdoc version.I tend to think that is not the developer responsibility, but rather the gem to always internally point to relative resources, make sure we do not load anything coming from somewhere else.
Hence I started a patch, but it is a bit long and I did want to keep this PR simple. I could however open another one with only relative paths for internal resources. Please, tell me if you'd be ready to merge something like that 🙂 (e.g:
require_relativeandautoload __dir__ + path)