Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/rdoc/ri/driver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -609,11 +609,11 @@ def ancestors_of klass

stores = classes[current]

break unless stores and not stores.empty?
next unless stores and not stores.empty?

klasses = stores.map do |store|
store.ancestors[current]
end.flatten.uniq
klasses = stores.flat_map do |store|
store.ancestors[current] || []
end.uniq

klasses = klasses - seen

Expand Down
24 changes: 24 additions & 0 deletions test/rdoc/test_rdoc_ri_driver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,30 @@ def test_ancestors_of
assert_equal %w[X Mixin Object Foo], @driver.ancestors_of('Foo::Bar')
end

def test_ancestors_of_chained_inclusion
# Store represents something like:
#
# module X
# end
#
# module Y
# include X
# end
#
# class Z
# include Y
# end
#
# Y is not chosen randomly, it has to be after Object in the alphabet
# to reproduce https://github.com/ruby/rdoc/issues/814.
store = RDoc::RI::Store.new @home_ri
store.cache[:ancestors] = { "Z" => ["Object", "Y"], "Y" => ["X"] }
store.cache[:modules] = %W[X Y Z]
@driver.stores = [store]

assert_equal %w[X Y Object], @driver.ancestors_of('Z')
end

def test_classes
util_multi_store

Expand Down