Hash type #177
Merged
Hash type #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soutaro It's ready to review now. Could you review this pull request? |
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
soutaro
reviewed
Jan 11, 2020
pocke
added a commit
to pocke/rbs
that referenced
this pull request
Jan 12, 2020
pocke
added a commit
to pocke/rbs
that referenced
this pull request
Jan 12, 2020
pocke
added a commit
to pocke/rbs
that referenced
this pull request
Jan 12, 2020
|
Thanks for your review. I've applied the all reviewed changes. |
deconstruct_keys also receives nil ruby#177 (comment) Hash#[] returns the value type without nil ruby#177 (comment) Fix `Hash[[:a, 1], [:b, 2]]` style arguments Small fixes * ruby#177 (comment) * ruby#177 (comment) * ruby#177 (comment) * ruby#177 (comment) Fix Hash#transform_*! types
|
I squashed the commit for review comments to one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds types to Hash class.
I think we can mark Hash class as "done" by this pull request.