Skip to content

Conversation

hanachin
Copy link
Contributor

No description provided.

@hanachin hanachin marked this pull request as ready for review February 16, 2020 17:04
@hanachin hanachin requested a review from soutaro February 16, 2020 17:06
@soutaro
Copy link
Member

soutaro commented Feb 19, 2020

@hanachin I pushed my fixes. Review them please. 🙏

Copy link
Contributor Author

@hanachin hanachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soutaro It looks great! thanks for the fix.

a, :<<, ToStr.new("world")
assert_send_type "(Integer) -> String",
a, :<<, 33
refute_send_type "(ToInt) -> String",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that assertion, thanks!

@soutaro soutaro merged commit 41e7af0 into ruby:master Feb 23, 2020
@hanachin hanachin deleted the string branch February 28, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants