Implement String#append_as_bytes(String | Integer, ...)
#11552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
string-append-as-bytes
branch
from
7a97c36 to
c5782da
Compare
This comment has been minimized.
This comment has been minimized.
casperisfine
changed the title
String#append_as_bytes(String | Integer, ...)
[Feature #20594] A handy method to construct a string out of multiple chunks. Contrary to `String#concat`, it doesn't do any encoding negociation, and simply append the content as bytes regardless of whether this result in a broken string or not. It's the caller responsibility to check for `String#valid_encoding?` in cases where it's needed. When passed integers, only the lower byte is considered, like in `String#setbyte`.
casperisfine
force-pushed
the
string-append-as-bytes
branch
from
c5782da to
f5e63d4
Compare
peterzhu2118
added a commit
to peterzhu2118/ruby
that referenced
this pull request
Sep 10, 2024
String#append_as_bytes was newly introduced in ruby#11552.
peterzhu2118
added a commit
that referenced
this pull request
Sep 10, 2024
String#append_as_bytes was newly introduced in #11552.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #20594]
A handy method to construct a string out of multiple chunks.
Contrary to
String#concat, it doesn't do any encoding negociation, and simply append the content as bytes regardless of whether this result in a broken string or not.It's the caller responsibility to check for
String#valid_encoding?in cases where it's needed.When passed integers, only the lower byte is considered, like in
String#setbyte.