Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Tweaks for Array#pop #11821

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[DOC] Tweaks for Array#pop #11821

merged 2 commits into from
Oct 8, 2024

Conversation

BurdetteLamar
Copy link
Member

No description provided.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Oct 8, 2024
nobu
nobu reviewed Oct 8, 2024
View reviewed changes
array.c Outdated
Comment on lines 1468 to 1470
* a.pop(2) # => ["bar", 2]
* a = [:foo, 'bar', 2]
* a.pop(50) # => [:foo, "bar", 2]
Copy link
Member

@nobu nobu Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No examples of a after pop?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added,

@peterzhu2118 peterzhu2118 merged commit a320833 into ruby:master Oct 8, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

@nobu nobu Awaiting requested review from nobu

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurdetteLamar @nobu @peterzhu2118