[DOC] Tweaks for Array#slice! #11902
Merged
+61
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit log too. |
Thanks, @nobu. |
array.c
Outdated
Comment on lines
4171
to
4195
| * With numeric arguments +start+ and +length+ given, | ||
| * removes +length+ elements from +self+ beginning at zero-based offset +start+; | ||
| * returns the removed objects in a new array: | ||
| * | ||
| * a = [:foo, 'bar', 2] | ||
| * a.slice!(0, 2) # => [:foo, "bar"] | ||
| * a # => [2] | ||
| * a = ['a', 'b', 'c', 'd'] | ||
| * a.slice!(1, 2) # => ["b", "c"] | ||
| * a # => ["a", "d"] | ||
| * a.slice!(0.1, 1.1) # => ["a"] | ||
| * a # => ["d"] | ||
| * | ||
| * If +start+ is negative, counts backwards from the end of +self+: | ||
| * | ||
| * a = ['a', 'b', 'c', 'd'] | ||
| * a.slice!(-2, 1) # => ["c"] | ||
| * a # => ["a", "b", "d"] | ||
| * | ||
| * If <tt>start + length</tt> exceeds the array size, | ||
| * removes and returns all elements from offset +start+ to the end: | ||
| * | ||
| * a = [:foo, 'bar', 2] | ||
| * a.slice!(1, 50) # => ["bar", 2] | ||
| * a # => [:foo] | ||
| * a = ['a', 'b', 'c', 'd'] | ||
| * a.slice!(2, 50) # => ["c", "d"] | ||
| * a # => ["a", "b"] | ||
| * | ||
| * If <tt>start == a.size</tt> and +length+ is non-negative, | ||
| * returns a new empty +Array+. | ||
| * returns a new empty array. |
There was a problem hiding this comment.
I think this is missing the nil return case, where start is out of range.
peterzhu2118
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.