Skip to content

Win32: Remove unreferenced COMDAT from object files #12107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Win32: Remove unreferenced COMDAT from object files #12107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6fe3fe
Win32: Remove unreferenced COMDAT from object files
nobu Nov 17, 2024
c129e01
Make `rb_ec_set_vm_stack` conformant to the C++11 requirement
nobu Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3583,7 +3583,7 @@ thread_alloc(VALUE klass)
return TypedData_Make_Struct(klass, rb_thread_t, &thread_data_type, th);
}

inline void
void
rb_ec_set_vm_stack(rb_execution_context_t *ec, VALUE *stack, size_t size)
{
ec->vm_stack = stack;
Expand Down
3 changes: 3 additions & 0 deletions win32/Makefile.sub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ OPTFLAGS = -O2b2xg-
OPTFLAGS = -O2sy-
!endif
!endif
!if $(MSC_VER) >= 1900
OPTFLAGS = $(OPTFLAGS) -Zc:inline
!endif
!if !defined(incflags)
incflags =
!endif
Expand Down
1 change: 0 additions & 1 deletion win32/mkexports.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ def each_export(objs)
elsif !l.sub!(/^(\S+) \([^@?\`\']*\)$/, '\1')
next
end
next if /\A_?ucrt_/ =~ l
when /DLL/
next unless l.sub!(/^\s*\d+\s+[[:xdigit:]]+\s+[[:xdigit:]]+\s+/, '')
else
Expand Down