Update child module name when parent gets a temp name set #12658
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `set_temporary_name` on a parent module the child modules
should get their name updated too.
Before:
```ruby
m = Module.new
m::N = Module.new
p m::N.name # => "#<Module:0x000000010d0a00b0>::N"
m.set_temporary_name("foo")
p m::N.name # => "#<Module:0x000000010d0a00b0>::N"
```
After:
```ruby
m = Module.new
m::N = Module.new
p m::N.name # => "#<Module:0x000000010d0a00b0>::N"
m.set_temporary_name("foo")
p m::N.name # => "foo::N"
```
[Bug #21094]
tenderlove
approved these changes
Jan 28, 2025
|
Shouldn’t this change too? m = Module.new
m::N = Module.new
m::N::O = Module.new
m.set_temporary_name("foo")
p m::N::O |
|
Ah yea that should work too. I'll fix it tomorrow morning. |
nobu
reviewed
Jan 29, 2025
| VALUE value = ce->value; | ||
| VALUE parental_path = *((VALUE *) payload); | ||
|
|
||
| rb_mod_set_temporary_name(value, build_const_path(parental_path, id)); |
There was a problem hiding this comment.
If the anonymous module has a constant that is not anonymous class or module, this will raise an exception.
And will crash on a non-class/module constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
set_temporary_nameon a parent module the child modules should get their name updated too.Before:
After:
[Bug #21094]