Raise ArgumentError if host component is nil #1278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oss92
force-pushed
the
net_http_no_host_error
branch
from
71a29f3 to
3b09147
Compare
esparta
added a commit
to esparta/ruby
that referenced
this pull request
Mar 9, 2018
A new exception is raised if an URI::HTTP is received and that object doesn't have a hostname property. Complementary to ruby#1278
k0kubun
pushed a commit
that referenced
this pull request
Aug 15, 2019
A new exception is raised if an URI::HTTP is received and that object doesn't have a hostname property. Complementary to #1278
hsbt
pushed a commit
to ruby/net-http
that referenced
this pull request
Feb 13, 2020
From: oss92 <mohamed.o.alnagdy@gmail.com> fix ruby/ruby#1278 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised
ArgumentError, "no host component for URI"ifuri.hostnameisnil.It used to raise
TypeError: can't dup NilClasswhich can be pretty vague for some developers.