OpenStruct: support for frozen string #1714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenStruct need minimal changes to switch to # frozen_string_literal: true The only method with mutable strings is `inspect`. Bug #14000: https://bugs.ruby-lang.org/issues/14000
|
There was one |
dbendaou
approved these changes
Oct 17, 2017
matzbot
pushed a commit
that referenced
this pull request
Oct 24, 2017
Patch adapted from Espartaco Palma. [GH-1714] [Bug #14000] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
Thanks for the PR! It is now merged. I adapted it a bit to avoid returning a frozen string. I highly doubt there's anyone calling Let me know if I've missed anything. |
mrkn
pushed a commit
to mrkn/ruby
that referenced
this pull request
Dec 1, 2017
Patch adapted from Espartaco Palma. [rubyGH-1714] [Bug #14000] git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@60406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStruct need minimal changes to switch to # frozen_string_literal: true
The only method with mutable strings is
inspect.Bug #14000: https://bugs.ruby-lang.org/issues/14000