Fix typo and specify error type. #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch was merged by r39277. Thanks. |
xaviershay
pushed a commit
to xaviershay/ruby
that referenced
this pull request
Nov 10, 2013
* test/ruby/test_thread.rb: fixed typo patched by Hiroki Matsue via ruby#248 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@39568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
jhawthorn
pushed a commit
to github/ruby
that referenced
this pull request
Oct 15, 2021
Try to get getblockparamproxy to support level > 0
kddnewton
pushed a commit
to kddnewton/ruby
that referenced
this pull request
Apr 4, 2022
* Include Rust YJIT in libruby_static.a Prior to this bigdecimal had linking issue which it detected during mkmf configuration and that made it not build properly. This let's us try to boot `make test-all`. This works by combining two archive libraries with ar(1). I also tried a couple of other approaches. `cargo rustc -- --emit obj` outputs an object file but at a path that's hard to find and considered internal to Cargo according to the manual. `ld -r --whole-archive` seems to be an alternative, but unfortunately is unavailable with the linker on macOS. * Don't change size of version map when taking blocks It was using Vec::remove which shifts the elements after it. The version map should always be `iseq->body->iseq_size` elements long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo and specify error type for expecting error.