Enhancements for ENV doc #2751
Enhancements for ENV doc #2751
Conversation
hash.c
Outdated
| * Raises an exception if a name or value is invalid. | ||
| * See {Invalid Names and Values}[#class-ENV-label-Invalid-Names+and+Values]. | ||
| * | ||
| * Adds new environment variables up to the first error encountered: |
There was a problem hiding this comment.
I'm not sure we can/should define the result after an error.
There was a problem hiding this comment.
For other errors, we say nothing about the state of ENV, implying that it's not changed (which is true). Here, the state of ENV -is- changed, and I think we have to say so.
Actually, I think this is a bug. On an error, ENV should never be changed.
There was a problem hiding this comment.
Demo:
irb
ENV.clear
=> {}
ENV.replace('foo' => '0', Object.new => Object.new)
Traceback (most recent call last):
5: from C:/Ruby26-x64/bin/irb.cmd:31:in <main>' 4: from C:/Ruby26-x64/bin/irb.cmd:31:in load'
3: from C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/irb-1.0.0/exe/irb:11:in <top (required)>' 2: from (irb):2 1: from (irb):2:in replace'
TypeError (no implicit conversion of Object into String)
ENV
=> {"foo"=>"0"}
There was a problem hiding this comment.
Also ENV.update has same behavior, and I think it is hard to guarantee your expectation as the change would be expected immediately in its block form.
There was a problem hiding this comment.
So, ready to merge now?
| * - A String. | ||
| * - An object that responds to \#to_str by returning a String, in which case that String will be used as the name or value. | ||
| * | ||
| * ==== Invalid Names and Values |
There was a problem hiding this comment.
Could the common requirements to name and value be extracted?
No description provided.