mswin build - install src zlib files, remove vcpkg zlib #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Jul 31, 2020
| run: | | ||
| $zlib = 'zlib1211.zip' | ||
| curl -fsSL -o $zlib --retry 10 https://zlib.net/$zlib | ||
| &'C:\Program Files\7-Zip\7z.exe' x -osrc/ext/zlib $zlib |
There was a problem hiding this comment.
As you've probably deduced, needed due to the space in the path. Above does generate a zlib.dll file, which needs to be available to the build.
The install code I use generates a manifest and the needed dll's are in bin/ruby_builtin_dlls. The mswin CI here does not run test-all or test-spec...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been doing this for quite a while with the ruby-loco mswin build, and it's fully tested and also used in CI elsewhere.