Skip to content

Conversation

postmodern
Copy link
Member

  • Fixed spelling errors.
  • Ensure all documentation is within 80 columns.
  • Remove double spacing after periods.

* Fixed spelling errors.
* Ensure all documentation is within 80 columns.
* Remove double spacing after periods.
@zzak
Copy link
Member

zzak commented Oct 10, 2013

Looks good, thanks! ❤️

@nobu
Copy link
Member

nobu commented Oct 10, 2013

Just curious.

(13/10/10 17:50), Postmodern wrote:

  • Remove double spacing after periods.

Is it wrong?

@zzak
Copy link
Member

zzak commented Oct 10, 2013

I generally remove them when I see them too. Mostly because they are actual tabs and not spaces.

On Oct 10, 2013, at 10:50 AM, Nobuyoshi Nakada notifications@github.com wrote:

Just curious.

(13/10/10 17:50), Postmodern wrote:

  • Remove double spacing after periods.

Is it wrong?

Reply to this email directly or view it on GitHub.

@drbrain
Copy link
Member

drbrain commented Oct 10, 2013

One space after a period is a recent development. Either is OK: http://theworldsgreatestbook.com/how-many-spaces-after-a-period/

For mono space text, I find two easier to read. Browsers remove the extra space so it causes no problem.

@godfather667
Copy link

The debate on this problem goes back apparently 100 years.
It was a fight among typesetters and proportional type standards.

I think double spaces are correct, but opinions differ!

But the issue is not resolved to this day!

  • Chastity and Competency have much in common,
    they both encompass their own punishment!!
    Charles E. Thornton, 2001

@postmodern
Copy link
Member Author

I think double spaces are correct, but opinions differ!

I see what you did there :) I remember being initially taught to use two spaces, and then later being taught to never use two spaces. This is one of those debates like how to use the oxford comma.

The cumulative benefit of this PR outweighs the downsides of two-space or one-space.

@zzak
Copy link
Member

zzak commented Oct 15, 2013

I will commit this soon, thank you!

@zzak zzak closed this in 86c24c4 Oct 16, 2013
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Oct 22, 2013
  comments for Curses, including period spacing and column width.

  This patch also fixed some typos. Thanks to @postmodern for the patch!
  [Fixes rubyGH-420] ruby#420


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
szuecs pushed a commit to szuecs/ruby that referenced this pull request Dec 11, 2013
  filesystem doesn't.  [ruby-trunk - Bug ruby#7618]

  Process specifications before other directories in case of bugs.
* test/rubygems/test_gem_doctor.rb:  Test for above.

* lib/rubygems.rb:  Updated version.

* test/rubygems/test_require.rb:  Fixed double require of benchmark.rb.
  RubyGems bug ruby#420.

* test/rubygems/test_gem_commands_check_command.rb:  Fixed unused
  variable warnings.
* test/rubygems/test_gem_commands_query_command.rb:  ditto
* test/rubygems/test_gem_installer.rb:  ditto


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
  filesystem doesn't.  [ruby-trunk - Bug ruby#7618]

  Process specifications before other directories in case of bugs.
* test/rubygems/test_gem_doctor.rb:  Test for above.

* lib/rubygems.rb:  Updated version.

* test/rubygems/test_require.rb:  Fixed double require of benchmark.rb.
  RubyGems bug ruby#420.

* test/rubygems/test_gem_commands_check_command.rb:  Fixed unused
  variable warnings.
* test/rubygems/test_gem_commands_query_command.rb:  ditto
* test/rubygems/test_gem_installer.rb:  ditto


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
  comments for Curses, including period spacing and column width.

  This patch also fixed some typos. Thanks to @postmodern for the patch!
  [Fixes rubyGH-420] ruby#420


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants