-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Curses documentation cleanups. #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
postmodern
commented
Oct 10, 2013
- Fixed spelling errors.
- Ensure all documentation is within 80 columns.
- Remove double spacing after periods.
* Fixed spelling errors. * Ensure all documentation is within 80 columns. * Remove double spacing after periods.
Looks good, thanks! ❤️ |
Just curious. (13/10/10 17:50), Postmodern wrote:
Is it wrong? |
I generally remove them when I see them too. Mostly because they are actual tabs and not spaces.
|
One space after a period is a recent development. Either is OK: http://theworldsgreatestbook.com/how-many-spaces-after-a-period/ For mono space text, I find two easier to read. Browsers remove the extra space so it causes no problem. |
The debate on this problem goes back apparently 100 years. I think double spaces are correct, but opinions differ! But the issue is not resolved to this day!
|
I see what you did there :) I remember being initially taught to use two spaces, and then later being taught to never use two spaces. This is one of those debates like how to use the oxford comma. The cumulative benefit of this PR outweighs the downsides of two-space or one-space. |
I will commit this soon, thank you! |
comments for Curses, including period spacing and column width. This patch also fixed some typos. Thanks to @postmodern for the patch! [Fixes rubyGH-420] ruby#420 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
filesystem doesn't. [ruby-trunk - Bug ruby#7618] Process specifications before other directories in case of bugs. * test/rubygems/test_gem_doctor.rb: Test for above. * lib/rubygems.rb: Updated version. * test/rubygems/test_require.rb: Fixed double require of benchmark.rb. RubyGems bug ruby#420. * test/rubygems/test_gem_commands_check_command.rb: Fixed unused variable warnings. * test/rubygems/test_gem_commands_query_command.rb: ditto * test/rubygems/test_gem_installer.rb: ditto git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
filesystem doesn't. [ruby-trunk - Bug ruby#7618] Process specifications before other directories in case of bugs. * test/rubygems/test_gem_doctor.rb: Test for above. * lib/rubygems.rb: Updated version. * test/rubygems/test_require.rb: Fixed double require of benchmark.rb. RubyGems bug ruby#420. * test/rubygems/test_gem_commands_check_command.rb: Fixed unused variable warnings. * test/rubygems/test_gem_commands_query_command.rb: ditto * test/rubygems/test_gem_installer.rb: ditto git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38691 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
comments for Curses, including period spacing and column width. This patch also fixed some typos. Thanks to @postmodern for the patch! [Fixes rubyGH-420] ruby#420 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e