Make the uninitialized module code handle modules that include other modules #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules We cannot check RCLASS_SUPER directly in the module, we need to walk the entire super pointer chain to handle included modules. However, we don't want to do this for refinement modules, as those are expected to have rb_cBasicObject at the end of the super chain. Fixes [Bug #18182] Fixes [Bug #18185]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot check RCLASS_SUPER directly in the module, we need to
walk the entire super pointer chain to handle included modules.
However, we don't want to do this for refinement modules, as those
are expected to have rb_cBasicObject at the end of the super chain.
Fixes [Bug #18182]
Fixes [Bug #18185]