YJIT: Refactor gen_opt_mod #6078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the
gen_opt_mod
function in YJIT to more closely match the style of similar functions and reduce the number of side exits (gen_opt_mod
is one of the top 20 exits in this most recent YJIT metric report).Most of these exits were caused by the situation where
%
is used for String interpolation.As part of this change we also call
rb_fix_mod_fix
directly rather than calling it throughrb_vm_opt_mod
, moving the% 0
check into thegen_opt_mod
function.Before the change:
After the change: