Fix parens on LIKELY in BASIC_OP_UNREDEFINED_P #6911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to hint to the compiler that it's likely that the BOP is not likely to be redefined (the bit is 0). Previously we were accidentally hinting to the compiler that it was non-zero (it was redefined) due to a misplaced parenthesis. Oops 😅.
This likely (though I'm still not 100% sure) was the cause of an MJIT regression from #6851 on nbody, optcarrot, and similarly math-heavy benchmarks (and it can't have helped the interpreter, though I haven't been able to see evidence of that). It also might depend on the compiler, I was never able to reproduce this on gcc 12.2 on arch linux, but was able to see a difference inside an ubuntu docker container built with gcc 9.4.
I was able to test this most easily by using:
cc @k0kubun @composerinteralia