Add Module#anonymous?.
#7966
Open
Add Module#anonymous?.
#7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaynetics
reviewed
Jun 21, 2023
| @@ -52,6 +52,14 @@ static inline void ROBJ_TRANSIENT_UNSET(VALUE obj); | |||
| */ | |||
| VALUE rb_mod_set_temporary_name(VALUE, VALUE); | |||
|
|
|||
| /** | |||
| * Return whether the module is anonymous or not. | |||
There was a problem hiding this comment.
it might be useful to document what it does for modules with anonymous elements in the "namespace path", e.g.
Class.new.tap { _1::C = Class.new }::C.anonymous? # true or false ?There was a problem hiding this comment.
It's still considered anonymous but if we accept this proposal I'll write a full set of specs.
|
Try on Playground: https://ruby.github.io/play-ruby?run=10952250729 |
ko1
force-pushed
the
ruby-const-permanent
branch
from
f5648f9
to
db90572
Compare
|
Needs tests. |
hsbt
force-pushed
the
ruby-const-permanent
branch
from
db90572
to
3a70a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/19742