Skip to content

Raise TypeError for bad IO::Buffer.map argument #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Raise TypeError for bad IO::Buffer.map argument #8728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d5bdc
Raise TypeError when IO::Buffer.map argument is neither IO nor implem…
headius Oct 21, 2023
afb3013
Use UNREACHABLE_CODE
headius Oct 21, 2023
0a2a7e1
Use macro for undef check
headius Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2870,8 +2870,15 @@ rb_io_descriptor(VALUE io)
return fptr->fd;
}
else {
return RB_NUM2INT(rb_funcall(io, id_fileno, 0));
VALUE fileno = rb_check_funcall(io, id_fileno, 0, NULL);
if (!UNDEF_P(fileno)) {
return RB_NUM2INT(fileno);
}
}

rb_raise(rb_eTypeError, "expected IO or #fileno, %"PRIsVALUE" given", rb_obj_class(io));

UNREACHABLE_RETURN(-1);
}

int
Expand Down
2 changes: 1 addition & 1 deletion test/ruby/test_io_buffer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_file_mapped
end

def test_file_mapped_invalid
assert_raise NoMethodError do
assert_raise TypeError do
IO::Buffer.map("foobar")
end
end
Expand Down