[PRISM] Use Prism inside eval
#9835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightbitraptor
force-pushed
the
mvh-prism-eval
branch
24 times, most recently
from
4ca423d to
e6e9dd6
Compare
|
This PR is ready, but currently blocked on two known issues:
|
|
Ignore my last comment, I'm going to get this merged first. |
kddnewton
force-pushed
the
mvh-prism-eval
branch
5 times, most recently
from
1ed696c to
752f815
Compare
- Don't use `build_options_scopes` We can inline the code here instead and avoid allocating all the extra arrays. - Create `pm_scope_node_t` objects with the correct local table, for the scope node returned from the parser. Co-Authored-By: Kevin Newton <kddnewton@gmail.com>
kddnewton
force-pushed
the
mvh-prism-eval
branch
from
752f815 to
4a78950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to use Prism inside
eval