[Bug #20245] Fix crash when checking symbol encoding #9871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
changed the title
[Bug #20245]
We sometimes pass in a fake string to sym_check_asciionly. This can crash
if sym_check_asciionly raises because it creates a CFP with the fake
string as the receiver which will crash if GC tries to mark the CFP.
For example, the following script crashes:
GC.stress = true
Object.const_defined?("\xC3")
peterzhu2118
force-pushed
the
invalid-symbol-crash
branch
from
162aee9 to
5f59624
Compare
casperisfine
reviewed
Feb 7, 2024
| { | ||
| if (!rb_enc_asciicompat(rb_enc_get(str))) return FALSE; | ||
| switch (rb_enc_str_coderange(str)) { | ||
| case ENC_CODERANGE_BROKEN: | ||
| if (fake_str) { |
There was a problem hiding this comment.
Instead of passing a boolean, couldn't you check for the STR_FAKESTR user flag?
There was a problem hiding this comment.
I guess we could, but we'll have to make STR_FAKESTR available outside of string.c. I'm not sure if I want to encourage more usage of the STR_FAKESTR flag.
There was a problem hiding this comment.
Agree with @peterzhu2118.
And the explicit flag makes inlining this function easier when it is false.
nobu
approved these changes
Feb 8, 2024
| { | ||
| if (!rb_enc_asciicompat(rb_enc_get(str))) return FALSE; | ||
| switch (rb_enc_str_coderange(str)) { | ||
| case ENC_CODERANGE_BROKEN: | ||
| if (fake_str) { |
There was a problem hiding this comment.
Agree with @peterzhu2118.
And the explicit flag makes inlining this function easier when it is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes pass in a fake string to sym_check_asciionly. This can crash if sym_check_asciionly raises because it creates a CFP with the fake string as the receiver which will crash if GC tries to mark the CFP.
For example, the following script crashes: