Skip to content

Commit 7584133

Browse files
committed
github source should default to secure protocol
Bundler 2 switched to secure https here c2e81f8 Insecure protocols should be avoided to prevent MITM attacks.
1 parent 5eb1937 commit 7584133

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/rubygems/request_set/gem_dependency_api.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def initialize(set, path)
214214
git_source :github do |repo_name|
215215
repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include? "/"
216216

217-
"git://github.com/#{repo_name}.git"
217+
"https://github.com/#{repo_name}.git"
218218
end
219219

220220
git_source :bitbucket do |repo_name|

test/rubygems/test_gem_request_set_gem_dependency_api.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def test_gem_github
183183

184184
assert_equal [dep("a")], @set.dependencies
185185

186-
assert_equal %w[git://github.com/example/repository.git master],
186+
assert_equal %w[https://github.com/example/repository.git master],
187187
@git_set.repositories["a"]
188188

189189
expected = { "a" => Gem::Requirement.create("!") }
@@ -196,7 +196,7 @@ def test_gem_github_expand_path
196196

197197
assert_equal [dep("a")], @set.dependencies
198198

199-
assert_equal %w[git://github.com/example/example.git master],
199+
assert_equal %w[https://github.com/example/example.git master],
200200
@git_set.repositories["a"]
201201

202202
expected = { "a" => Gem::Requirement.create("!") }

0 commit comments

Comments
 (0)