Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Report 1-based position in vcf-report log messages #231

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix: Report 1-based position in vcf-report log messages #231

merged 1 commit into from
Jan 6, 2022

Conversation

fxwiegand
Copy link
Contributor

Just a quick PR that fixes #230.

@fxwiegand fxwiegand self-assigned this Jan 6, 2022
FelixMoelder
FelixMoelder approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@FelixMoelder FelixMoelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward to me. :)

@FelixMoelder FelixMoelder merged commit bcf6260 into rust-bio:master Jan 6, 2022
@fxwiegand
Copy link
Contributor Author

Looks straight forward to me. :)

That's because it is! 😄

@fxwiegand fxwiegand deleted the warn-1-bases-pos branch January 6, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMoelder FelixMoelder FelixMoelder approved these changes

@johanneskoester johanneskoester Awaiting requested review from johanneskoester

Assignees

@fxwiegand fxwiegand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vcf-report] 0-based position reporting for 1-based VCF file
2 participants
@fxwiegand @FelixMoelder