Skip to content

Conversation

johanneskoester
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Apr 25, 2019

Pull Request Test Coverage Report for Build 606

  • 12 of 27 (44.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 48.491%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bam/record.rs 9 24 37.5%
Totals Coverage Status
Change from base Build 600: -0.02%
Covered Lines: 13429
Relevant Lines: 27694

💛 - Coveralls

@johanneskoester
Copy link
Contributor Author

@dlaehnemann are the failing tests here related to what you fixed recently? I don't recall exactly what was the problem at that time.

@dlaehnemann
Copy link
Member

Jep, it's exactly the same error as before. And looking at the index code, that's the old one. So it looks like you need to rebase your branch onto the current master (the network graph confirms this: https://github.com/rust-bio/rust-htslib/network).

@johanneskoester
Copy link
Contributor Author

Thanks. Weird, I considered that, but then I did not see an update branch button here, which made me assume that it is in sync with the master branch... Anyway, let's see if it works now.

@FelixMoelder
Copy link
Member

Just tested the trait on rbt consensus_from_bam-branch and everything looks fine now.

@johanneskoester johanneskoester merged commit 3f5178e into master Apr 26, 2019
@johanneskoester johanneskoester deleted the sequence-read-trait branch April 26, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants