Skip to content

Conversation

johanneskoester
Copy link
Contributor

Previously, we had one buffer for all. We discovered that this could lead to memory issues, and also race conditions in certain cases. Now, each call to info() and format() will allocate its own buffer. Alternatively it is possible to pass a shared buffer via info_shared_buffer() and format_shared_buffer().

@coveralls
Copy link

coveralls commented Nov 19, 2020

Pull Request Test Coverage Report for Build 372866036

  • 68 of 82 (82.93%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bcf/mod.rs 16 18 88.89%
src/bcf/record.rs 52 64 81.25%
Totals Coverage Status
Change from base Build 372795131: -0.04%
Covered Lines: 10823
Relevant Lines: 11531

💛 - Coveralls

@johanneskoester johanneskoester merged commit 588a85d into master Nov 19, 2020
@johanneskoester johanneskoester deleted the separate-buffers branch November 19, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants