Skip to content

Use MAX_MSATS instead of magic value #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

Use MAX_MSATS instead of magic value #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cec735
Use MAX_MSATS instead of magic value
benthecarman Aug 25, 2025
d92d64e
Fix typo
benthecarman Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/amount.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use core::fmt;

/// An amount of Bitcoin
///
/// Sadly, because lightning uses "milli-satoshis" we cannot directly use rust-bitcon's `Amount`
/// Sadly, because lightning uses "milli-satoshis" we cannot directly use rust-bitcoin's `Amount`
/// type.
///
/// In general, when displaying amounts to the user, you should use [`Self::sats_rounding_up`].
Expand Down Expand Up @@ -89,8 +89,8 @@ impl Amount {
#[inline]
pub const fn saturating_add(self, rhs: Amount) -> Amount {
match self.0.checked_add(rhs.0) {
Some(amt) if amt <= 21_000_000_0000_0000_000 => Amount(amt),
_ => Amount(21_000_000_0000_0000_000),
Some(amt) if amt <= MAX_MSATS => Amount(amt),
_ => Amount(MAX_MSATS),
}
}

Expand Down
Loading