test: add test for push slice minimal #4368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test push_slice and push_slice_nom_minimal from OP_1...OP_16 and OP_1NEGATE
Pull Request Test Coverage Report for Build 14546094216Details
💛 - Coveralls |
|
In 2b37583: The format bot will pull this apart but the test looks good to me. |
apoelstra
added a commit
that referenced
this pull request
Apr 26, 2025
afd4ec8 test: push minimality check for zero(empty) (ChrisCho-H) Pull request description: Following #4368. I omitted to test OP_0(empty bytes) and can be covered by this PR. ACKs for top commit: apoelstra: ACK afd4ec8; successfully ran local tests Tree-SHA512: a3643227f9dfde71d5c5707bf11804e0e26eff43346c0443abdd805f0ffad284c3090e22a0bda34e54e1185a980adc7511724db401c04b55a8be79d67a3fce6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4322.
Test
push_sliceandpush_slice_nom_minimalfrom OP_1...OP_16 and OP_1NEGATE.