Introduce and enforce import statement policy #4883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The github basebranch stuff smells a bit. |
jrakibi
reviewed
Aug 19, 2025
| fi | ||
|
|
||
| for crate in "${crates[@]}"; do | ||
| violations=$(git diff "$base_branch"...HEAD | grep "^+" | grep -E "use ${crate}::" | grep -v "pub use ${crate}::" || true) |
There was a problem hiding this comment.
Should we limit this rule to only *.rs files, so it doesn’t apply to documentation or *.md files ?
git diff "$base_commit"...HEAD -- '*.rs'
There was a problem hiding this comment.
Yeah that is a good idea.
tcharding
force-pushed
the
push-soowmuonmkol
branch
from
a650cde to
94a4c24
Compare
|
Needs rebase after #4895 (remove coveralls) |
Recently we have started documenting repository coding policy in `docs/policy.md` to help contributors. Introduce a script that can be used to enforce the policy rules. At this stage only enforce a subsection of import statement policy.
tcharding
force-pushed
the
push-soowmuonmkol
branch
from
94a4c24 to
c0f5db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and enforce policy around import statements using
crate::Fooinstead ofunits::Foo.