Skip to content

remove ToPkCtx, allow hardened derivation steps (and wildcards) in DescriptorPublicKey #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 3, 2021
Merged

remove ToPkCtx, allow hardened derivation steps (and wildcards) in DescriptorPublicKey #216

merged 13 commits into from
Jan 3, 2021

Conversation

apoelstra
Copy link
Member

No description provided.

@apoelstra apoelstra force-pushed the 2020-12--hardened-wildcard branch from dc0708d to b7d4536 Compare January 2, 2021 20:32
apoelstra
apoelstra commented Jan 2, 2021
View reviewed changes
sanket1729
sanket1729 reviewed Jan 2, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the first few commits. Only minor nits so far. Will review the rest later. I think based on ToPkCtx, I will also have to update the elements miniscript.

sanket1729
sanket1729 previously approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b7d4536 .
Surprisingly easy to review despite the large diff :). I like that cleaner API over all the ToPkCtx stuff we had.

@sanket1729
Copy link
Member

The title of the PR says WalletPublicKey but codebase has DescriptorPublicKey. Did you intend to rename it?

@apoelstra
Copy link
Member Author

lol, I'll fix the title. In my head I constantly think of WalletPublicKey as the more obvious name, but no, I don't intend to change it.

@apoelstra apoelstra changed the title remove ToPkCtx, allow hardened derivation steps (and wildcards) in WalletPublicKey remove ToPkCtx, allow hardened derivation steps (and wildcards) in DescriptorPublicKey Jan 2, 2021
sanket1729
sanket1729 approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck 9646ad8

@sanket1729 sanket1729 mentioned this pull request Jan 3, 2021
Merged
@sanket1729 sanket1729 merged commit 95811b2 into master Jan 3, 2021
@sanket1729 sanket1729 deleted the 2020-12--hardened-wildcard branch January 3, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apoelstra @sanket1729