descriptor/key: fix master fingerprint when there are none #265
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, fwiw this is not compatible with Bitcoin Core's behaviour (which the previous code tried to emulate). Is it problematic? I mean both versions are pretty explicit about "there is no parent". |
|
I think we should just stick to how core does it and take the first 4 bytes. My rationale is that we don't want users to rely on master fingerprint being 0's for checking that there is no parent. |
|
Where was the previous panic? |
|
In |
|
FWIW i'll update this soon (tm) |
We gave 20 bytes to Fingerprint's From which would then assert the length is 4. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
darosior
force-pushed
the
fix_master_fingerprint
branch
from
2f6ce75 to
775da51
Compare
|
Finally got to update this :) |
|
ACK 775da51 Will leave it to Sanket whether we should go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's clearer to return
0x00000000if we don't know the origin. This is arguably not an API break since, well, this code path could not be taken without panic'ing before.