-
Notifications
You must be signed in to change notification settings - Fork 160
Return Weight type for max_weight_to_satisfy methods #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Weight type for max_weight_to_satisfy methods #664
Conversation
54ba5da
to
3adf211
Compare
I'm not sure if there should be a more specific error added or if there is a better one to use then the general one I picked here. |
Fine to use the general one for now. I have an ambitious PR in the works that will try to add span information etc to errors so any "extra" work you do now will just get overwritten when I finish that. |
3adf211
to
be516fb
Compare
Rebased. |
You need to run |
be516fb
to
fac615d
Compare
Thanks, done. |
7615aed
to
f04c7c6
Compare
Now this appears to be based on the tip of #661 rather than on master. |
f04c7c6
to
7c5f3dc
Compare
Now sure how I managed that. I'm now showing 4aaedf is now the previous commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7c5f3dc
Return Weight type for max_weight_to_satisfy methods.