Skip to content

Return Weight type for max_weight_to_satisfy methods #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yancyribbens
Copy link
Contributor

Return Weight type for max_weight_to_satisfy methods.

@yancyribbens yancyribbens force-pushed the add-weight-type-to-satisfy-methods branch from 54ba5da to 3adf211 Compare March 23, 2024 18:23
@yancyribbens
Copy link
Contributor Author

I'm not sure if there should be a more specific error added or if there is a better one to use then the general one I picked here.

@apoelstra
Copy link
Member

I'm not sure if there should be a more specific error added or if there is a better one to use then the general one I picked here.

Fine to use the general one for now. I have an ambitious PR in the works that will try to add span information etc to errors so any "extra" work you do now will just get overwritten when I finish that.

@apoelstra
Copy link
Member

Could you rebase this though? The rebase will be trivial, it's just that #661 made me change the lockfiles in my local CI so now they don't work without it. (I could change them back on my end but I'm being lazy and I know you're comfortable rebasing stuff.)

utACK 3adf211

@yancyribbens yancyribbens force-pushed the add-weight-type-to-satisfy-methods branch from 3adf211 to be516fb Compare March 25, 2024 12:46
@yancyribbens
Copy link
Contributor Author

Rebased.

@apoelstra
Copy link
Member

You need to run cargo +nightly fmt in this repo.

@yancyribbens yancyribbens force-pushed the add-weight-type-to-satisfy-methods branch from be516fb to fac615d Compare March 25, 2024 15:43
@yancyribbens
Copy link
Contributor Author

You need to run cargo +nightly fmt in this repo.

Thanks, done.

@yancyribbens yancyribbens force-pushed the add-weight-type-to-satisfy-methods branch 2 times, most recently from 7615aed to f04c7c6 Compare March 25, 2024 16:29
@apoelstra
Copy link
Member

Now this appears to be based on the tip of #661 rather than on master.

@yancyribbens yancyribbens force-pushed the add-weight-type-to-satisfy-methods branch from f04c7c6 to 7c5f3dc Compare March 25, 2024 22:52
@yancyribbens
Copy link
Contributor Author

Now this appears to be based on the tip of #661 rather than on master.

Now sure how I managed that. I'm now showing 4aaedf is now the previous commit.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7c5f3dc

@apoelstra apoelstra merged commit fb3f36a into rust-bitcoin:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants