12.x: fix CI #834
Merged
12.x: fix CI #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The stranded doccomment was associated with commented-out code, but rustdoc was applying it to the nearest non-commented-out item. Just delete all the commented-out stuff since we're not going to reenable it in 12.x.)
On 12.x apparently the "large error" (actually a copy of Self) returned by the plan API is a fair bit larger than it is on master, so we need to increase this threshold by a bunch.
apoelstra
force-pushed
the
2025-07_ci-0.12
branch
from
ad25096 to
cf97cb7
Compare
Don't bother with the cronjob to update this. We'll just leave the nightly compiler version fixed forever on these old versions (or update it on an ad-hoc basis).
apoelstra
force-pushed
the
2025-07_ci-0.12
branch
from
cf97cb7 to
2019e97
Compare
|
This one should be good to go (though I intend to run my local CI through it in full, which should now pass). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should get us green CI, and pins the nightly compiler version so that it stays green.