Rename secret_bytes to to_secret_bytes
#863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we did elsewhere add a new function and deprecate the old one. Done for the two places we missed: - `ecdh::SharedSecret` - `Keypair` Close: rust-bitcoin#845
tcharding
changed the title
secret_bytes to to_secret_bytes
stevenroose
approved these changes
Sep 24, 2025
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…ecret_bytes`
fc269eedd8a49cd5a61c372e803f6d7d3e8fc376 Rename secret_bytes to to_secret_bytes (Tobin C. Harding)
Pull request description:
As we did elsewhere add a new function and deprecate the old one.
Done for the two places we missed:
- `ecdh::SharedSecret`
- `Keypair`
Close: #845
ACKs for top commit:
apoelstra:
ACK fc269eedd8a49cd5a61c372e803f6d7d3e8fc376; successfully ran local tests
Tree-SHA512: a9a374978c2f5a6d37464acd3c00e5e9487f30f07987c9e69e39cf4419ce85fbc39f4c5e03d42abdec25356d143f9bfcf3944e024cd6f804a7a3afb468cee76d
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…ecret_bytes`
fc269eedd8a49cd5a61c372e803f6d7d3e8fc376 Rename secret_bytes to to_secret_bytes (Tobin C. Harding)
Pull request description:
As we did elsewhere add a new function and deprecate the old one.
Done for the two places we missed:
- `ecdh::SharedSecret`
- `Keypair`
Close: #845
ACKs for top commit:
apoelstra:
ACK fc269eedd8a49cd5a61c372e803f6d7d3e8fc376; successfully ran local tests
Tree-SHA512: a9a374978c2f5a6d37464acd3c00e5e9487f30f07987c9e69e39cf4419ce85fbc39f4c5e03d42abdec25356d143f9bfcf3944e024cd6f804a7a3afb468cee76d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did elsewhere add a new function and deprecate the old one.
Done for the two places we missed:
ecdh::SharedSecretKeypairClose: #845