Skip to content

Add WIP Si4703 FM radio turner (receiver) #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

Add WIP Si4703 FM radio turner (receiver) #207

merged 1 commit into from
Oct 14, 2019

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Oct 6, 2019

I started a driver for these FM radio turners.

@rust-highfive
Copy link

r? @adamgreig

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Oct 6, 2019
@eldruin
Copy link
Member Author

eldruin commented Oct 13, 2019

Hi, is there something missing here?

@eldruin eldruin changed the title Add WIP Si470x FM radio turner (receiver) Add WIP Si4703 FM radio turner (receiver) Oct 13, 2019
@jamesmunns
Copy link
Member

@eldruin nope, thanks for the reping!

jamesmunns
jamesmunns approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

bors bot added a commit that referenced this pull request Oct 14, 2019
@bors @eldruin
Merge #207
7fcbe69 
207: Add WIP Si4703 FM radio turner (receiver) r=jamesmunns a=eldruin

I started a driver for these FM radio turners.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 14, 2019

Build succeeded

@bors bors bot merged commit c4356b1 into rust-embedded:master Oct 14, 2019
@eldruin eldruin deleted the add-wip-si470x branch October 14, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns jamesmunns approved these changes

@berkus berkus Awaiting requested review from berkus berkus is a code owner

@rahul-thakoor rahul-thakoor Awaiting requested review from rahul-thakoor rahul-thakoor is a code owner

@RandomInsano RandomInsano Awaiting requested review from RandomInsano RandomInsano is a code owner

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @rust-highfive @jamesmunns @adamgreig